-
Notifications
You must be signed in to change notification settings - Fork 1
feat: time of day pieces #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da6c1b5 to
9f6afb7
Compare
3096a98 to
c01f9b8
Compare
43f94cd to
1e3735e
Compare
1e3735e to
5023596
Compare
mint-dewit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general
packages/webui/src/client/ui/RundownView/SelectedElementsContext.tsx
Outdated
Show resolved
Hide resolved
| enable: { | ||
| start: regenerateTimelineAt, | ||
| }, | ||
| layer: '__timeline_regeneration_trigger__', // Some unique name, as callbacks need to be on a layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should collect layer names like this somewhere and document them? Although I have my doubts about anyone ever finding that documentation
# Conflicts: # packages/job-worker/src/playout/timeline/generate.ts # packages/live-status-gateway/src/collections/pieceInstancesHandler.ts
…xt.tsx Co-authored-by: Mint de Wit <[email protected]>
# Conflicts: # packages/job-worker/src/playout/timeline/generate.ts # packages/shared-lib/src/peripheralDevice/peripheralDeviceAPI.ts
No description provided.