Skip to content

Conversation

@Julusian
Copy link
Collaborator

@Julusian Julusian commented Jan 8, 2025

No description provided.

@Julusian Julusian force-pushed the feat/time-of-day-pieces branch from da6c1b5 to 9f6afb7 Compare January 8, 2025 14:49
@Julusian Julusian force-pushed the feat/time-of-day-pieces branch from 3096a98 to c01f9b8 Compare February 4, 2025 13:02
@Julusian Julusian force-pushed the feat/time-of-day-pieces branch 2 times, most recently from 43f94cd to 1e3735e Compare February 12, 2025 13:43
@Julusian Julusian force-pushed the feat/time-of-day-pieces branch from 1e3735e to 5023596 Compare February 12, 2025 14:06
@Julusian Julusian marked this pull request as ready for review February 12, 2025 14:41
Copy link

@mint-dewit mint-dewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

enable: {
start: regenerateTimelineAt,
},
layer: '__timeline_regeneration_trigger__', // Some unique name, as callbacks need to be on a layer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should collect layer names like this somewhere and document them? Although I have my doubts about anyone ever finding that documentation

@Julusian Julusian changed the base branch from bbc-release52 to bbc-release53 March 13, 2025 14:45
Julusian and others added 4 commits March 13, 2025 14:46
# Conflicts:
#	packages/job-worker/src/playout/timeline/generate.ts
#	packages/live-status-gateway/src/collections/pieceInstancesHandler.ts
# Conflicts:
#	packages/job-worker/src/playout/timeline/generate.ts
#	packages/shared-lib/src/peripheralDevice/peripheralDeviceAPI.ts
@Julusian Julusian merged commit 6ace25b into bbc-release53 Mar 13, 2025
65 checks passed
@Julusian Julusian deleted the feat/time-of-day-pieces branch March 13, 2025 15:04
Julusian added a commit that referenced this pull request Mar 13, 2025
Julusian added a commit that referenced this pull request Mar 24, 2025
Julusian added a commit that referenced this pull request Sep 23, 2025
PeterC89 pushed a commit that referenced this pull request Nov 6, 2025
Julusian added a commit that referenced this pull request Jan 6, 2026
Julusian added a commit that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants